Repository navigation
chore: integrate product-review follow-ups into master - #145
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes have no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Integrates tested lifecycle-inspection follow-ups into master, including routing measurements, runtime-continuity documentation, deterministic tests, and packaging updates.
Changes:
- Adds first-attempt routing metrics and bounded metadata.
- Adds workflow, continuity, expiry, and recovery tests.
- Publishes and package-tests runtime-continuity guidance.
| File | Description |
|---|---|
vitest.config.ts |
Discovers TypeScript and MJS tests. |
test/workflow-guidance.test.ts |
Validates documented workflow examples. |
test/runtime-continuity.test.ts |
Tests persistence and recovery boundaries. |
test/orchestration-runtime.test.ts |
Tests expiry wake retirement. |
test/e2e/controller-routing-evaluation.mjs |
Provides routing evaluation helpers. |
test/e2e/controller-routing-conformance.mjs |
Records evaluation and runtime metadata. |
test/controller-routing-evaluation.test.mjs |
Tests routing metrics and invariants. |
scripts/package-smoke.mjs |
Verifies continuity guide packaging. |
README.md |
Links runtime continuity guidance. |
package.json |
Includes the guide in published packages. |
docs/RUNTIME_CONTINUITY.md |
Documents continuity and recovery boundaries. |
docs/REFERENCE.md |
Clarifies runtime guarantees. |
docs/CONTROLLER_ROUTING_EVAL.md |
Documents first-attempt measurements. |
biome.json |
Enables linting for new MJS files. |
AGENTS.md |
Clarifies orchestration wake retention. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainline integration
Bring the already reviewed/tested #142, #143 and signed Copilot follow-up into
master. Those PRs were merged into the stack branch, not the default branch.masterat53da7be5620775d51db40cc65d3997ee12de3df6(already contains docs: codify bug regressions and feature invariants #139/feat: add read-only lifecycle inspection #140).feat/lifecycle-inspectionat10bf73060502a9207917b93377b17d4ae8d91592.7cb92ab1632ac04816e56eb986f68854d5f59fc9; no extra code edits or history rewrite.Includes first-attempt workflow measurements and bounded response metadata, existing-example/routing invariants, runtime-continuity/recovery documentation, packaging and deterministic boundary tests. Guidance problem did not reproduce; production workflow copy/parser/fixtures remain unchanged. The Copilot missing-backup crash was not reproducible; strict recovery-snapshot checks remain, with explicit precondition coverage and exact tombstone-free snapshot assertions. Corrected LoopList versus interactive storage/actions documentation.
Evidence
Verified tree/ancestor chain and clean cumulative diff. Prior exact-tree gate:72 files /1,225 coverage tests;22 overlapping properties; coverage90.60/84.95/96.43/95.28; typechecks/build/package124/public types/audit0/LSP/diffs pass, two established lint warnings. Normal push hooks passed. Signed thematic commits verify G. Latest follow-up Linux/Windows CI run37526683820 passes at7cb92ab. New mainline PR must pass its applicable CI/CodeQL checks before merge.
Copilot response: #143 (comment).
User requested continuation of the stated mainline merge step. No auto-merge, admin bypass, force-push, branch deletion, or release.
.vitest/stays untracked/excluded. No daemon/outbox/election/recoverable-monitor implementation, OS-death simulation, recruited operator study or model-wide effectiveness claim. Pre-existing partial failed-run routing-observation retention remains documented, not fixed.